-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added image-to-image task for ORT Pipeline #2031
Added image-to-image task for ORT Pipeline #2031
Conversation
awesome ! don't hesitate to ping me for review when it's ready ! |
Sure. Writing some tests. Will update you soon. |
Suggest Changes if Any. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a few comments and suggestions, mostly to follow the same testing pipeline we have for other ORTModels:
- base the TestCase on a simpler task (I think u based on generative tasks)
- use setup to export/use an exported model
- use tiny models for faster testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
did you test io binding locally ?
Yes. |
Should I add a test for that? |
we won't be able to test it until #2024 is re-enabled. will merge this now. |
What does this PR do?
Fixes #2030
Image To Image task consist lot more than Diffusion and there are transformer based model such as Swin.
This PR adds the support for pielining image-to-image task with ORTModelForImage2Image.
e.g.
Before submitting
Who can review?
@fxmarty, @echarlaix, @JingyaHuang, @michaelbenayoun